#14 new
Yaroslav Markin

Fix en-US.yml paddings for ActiveRecord

Reported by Yaroslav Markin | September 1st, 2008 @ 12:22 PM

Padding that is currently in Rails Edge is wrong:

Code does lookups for activerecord.models/attributes not activerecord.errors.models/attributes

Proof:

@activerecord base.rb L1250@:


        I18n.translate(defaults.shift, options.merge(:default => defaults, :scope => [:activerecord, :attributes]))

@active_record_helper L198@:


              object_name = I18n.t(object_name, :default => object_name, :scope => [:activerecord, :models], :count => 1)

Comments and changes to this ticket

  • Yaroslav Markin

    Yaroslav Markin September 1st, 2008 @ 12:25 PM

    Patch breaks ActiveRecord tests (24 failures)

  • Yaroslav Markin

    Yaroslav Markin September 1st, 2008 @ 12:26 PM

    For instance,

    
     18) Failure:
    test_validates_inclusion_of(ValidationsTest)
        [./test/cases/validations_test.rb:625:in `test_validates_inclusion_of'
         ./test/cases/../../../activesupport/lib/active_support/testing/setup_and_teardown.rb:94:in `__send__'
         ./test/cases/../../../activesupport/lib/active_support/testing/setup_and_teardown.rb:94:in `run']:
    <"is not included in the list"> expected but was
    <"custom message">.
    
  • Yaroslav Markin

    Yaroslav Markin September 1st, 2008 @ 08:30 PM

    Wontfix: works as intented, Iain is going to document key behavior for activerecord translation, I believe.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Repository for collecting Locale data for Ruby on Rails I18n as well as other interesting, Rails related I18n stuff

People watching this ticket

Attachments

Pages